Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Extra Methods #91

Merged
merged 3 commits into from
Nov 10, 2024
Merged

feat: Add Extra Methods #91

merged 3 commits into from
Nov 10, 2024

Conversation

cjmellor
Copy link
Owner

Description

This pull request includes updates to the README.md documentation, new methods in the HasAchievements concern, and adjustments to the test cases to reflect these changes. The most important changes include the addition of new methods for retrieving user achievements and specific progress, as well as the corresponding updates in the documentation and test cases.

Documentation Updates:

  • Moved the "Revoke Achievement" section to a new location in README.md for better organization. [1] [2]
  • Updated method calls in README.md to reflect new method names for retrieving achievements and specific progress.

New Methods in HasAchievements Concern:

  • Added getUserAchievements method to retrieve all achievements of a user.
  • Added achievementsWithSpecificProgress method to retrieve achievements with a specific progress value.

Test Case Adjustments:

  • Updated test cases to use the new getUserAchievements method instead of directly accessing the achievements property. [1] [2] [3] [4] [5] [6]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related Issues and Pull Requests

  • Issue #...
  • PR #...

Testing

Please provide a passing test where possible. This package uses PestPHP

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation [OPTIONAL]

 - integrate into existing tests
- update docs
 - replace code with new method in test
 - update docs
@cjmellor cjmellor added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 10, 2024
@cjmellor cjmellor merged commit 2110584 into main Nov 10, 2024
14 checks passed
@cjmellor cjmellor deleted the add-better-methods branch November 10, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant