Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wrap logic in intval #84

Merged
merged 2 commits into from
Jun 22, 2024
Merged

fix: Wrap logic in intval #84

merged 2 commits into from
Jun 22, 2024

Conversation

cjmellor
Copy link
Owner

Description

Resolves #83

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related Issues and Pull Requests

Testing

Please provide a passing test where possible. This package uses PestPHP

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation [OPTIONAL]

@cjmellor cjmellor added the bug Something isn't working label Jun 22, 2024
@cjmellor cjmellor self-assigned this Jun 22, 2024
@cjmellor cjmellor linked an issue Jun 22, 2024 that may be closed by this pull request
[Bug]: Comparison fails in recordStreak #83
Closed
@cjmellor cjmellor merged commit ef3c9c7 into main Jun 22, 2024
@cjmellor cjmellor deleted the 83-bug-comparison-fails-in-recordstreak branch June 22, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjmellor cjmellor

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Comparison fails in recordStreak
1 participant
@cjmellor