Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom tables #80

Closed
wants to merge 8 commits into from
Closed

Custom tables #80

wants to merge 8 commits into from

Conversation

brianclogan
Copy link

@brianclogan brianclogan commented May 4, 2024

Description

Add config options for all tables to have custom names, to prevent any collision with existing tables in projects.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please provide a passing test where possible. This package uses PestPHP

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works (I didn't add tests, since all it did was change the names of tables. If the tests pass, that means the changes worked.)
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation [OPTIONAL]

@brianclogan
Copy link
Author

WIP, tests wouldn't run on my fork for some reason.

@brianclogan
Copy link
Author

@cjmellor it seems that PHP8.3 has some flaky tests that work in PHP8.2 and PHP8.1

Is this a known issue?

@cjmellor cjmellor added the enhancement New feature or request label Jun 12, 2024
@cjmellor
Copy link
Owner

@brianclogan Sorry for the late reply.

I think yes, there are flaky tests in 8.3. Not able to figure it out just yet.

Is your PR ready for review? Happy to merge it when you're ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants