fix Remove 'level_id' migration #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the 'level_id' field from the specified table in the configuration file instead of assuming it hasn't been customized and is the default 'users' table - consider that the field contains a foreign key
cjmellor
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The migration introduced in the PR #75 cannot be executed because the 'level_id' field contains a foreign key constraint preventing the field from being removed.
Additionally, it was not taken into account that the user may have modified the 'users' table in the configuration file.
This PR aims to fix these 2 issues.
Type of Change
Related Issues and Pull Requests
level_idFrom Table #75Testing
Please provide a passing test where possible. This package uses PestPHP
Checklist: