Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_streak_histories_table.php.stub #54

Closed
wants to merge 1 commit into from

Conversation

pablodiegoo
Copy link

Suggestion

Description

Issue related on #53

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related Issues and Pull Requests

Testing

Please provide a passing test where possible. This package uses PestPHP

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation [OPTIONAL]

@cjmellor
Copy link
Owner

cjmellor commented Oct 31, 2023

Hi @pablodiegoo

Thanks for this, but I'd rather not have a default on these columns as streaks are optional.

My suggestion is get the migration via vendor:publish and run that instead, as it seems unique to you.

Close: #53

@cjmellor cjmellor closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants