Fire Multiple Levelled Up Events #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the level-up system to appropriately fire events for each level gained and not just the final level. Removed the direct update of the user's level within the levelUp method and instead implemented a function to calculate and update to the highest possible level based on a user's current points. This ensures that levelling up and firing of events occur for each level achieved, rather than skipping to the final level. Additionally, methods within the GiveExperience.php file were rearranged for better readability and maintenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to appropriately fire events for each level gained and not just the final level. Removed the direct update of the user's level within the
levelUpmethod and instead implemented a function to calculate and update to the highest possible level based on a user's current points. This ensures that levelling up and firing of events occur for each level achieved, rather than skipping to the final level.Further fixes #36