Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix url assembly in forceUpdate #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix url assembly in forceUpdate #160

wants to merge 1 commit into from

Conversation

womoak75
Copy link

@womoak75 womoak75 commented Nov 1, 2024

in method

bool esp32FOTA::forceUpdate(const char* firmwareHost, uint16_t firmwarePort, const char*  firmwarePath, bool validate )

url assembly was missing a '://' between protocol and host part.

forceUpdate("update.myhost.com", 80, "/firmware.bin", true)

resulted in

"httpupdate.myhost.com:80/firmware.bin"

instead of

"http://update.myhost.com:80/firmware.bin"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@womoak75