Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELK] Change raw mappings to support search fields #665

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

valeriocos
Copy link
Member

@valeriocos valeriocos commented Jul 21, 2019

This PR showcases the effort on the Jira connector needed to change the mapping of the raw items, which would leverage on the search_fields metadata attribute.

Note data the test data should be recreated to include the search_fields attribute

@coveralls
Copy link

coveralls commented Jul 21, 2019

Pull Request Test Coverage Report for Build 2062

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.05%) to 77.021%

Files with Coverage Reduction New Missed Lines %
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/raw/github.py 2 95.0%
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/raw/launchpad.py 6 0%
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/raw/gitlab.py 10 52.38%
Totals Coverage Status
Change from base Build 2058: 0.05%
Covered Lines: 7260
Relevant Lines: 9426

💛 - Coveralls

This code changes the filter-raw parameter to
`search_terms`. This change is needed to
use the new Perceval metadata attribute
`search_terms` to filter raw data.

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the Jira raw items.
The new mapping is the following:
```
{
 "dynamic":true,
 "properties": {
    "data": {
       "dynamic":false,
       "properties": {}
   }
  }
}
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
@valeriocos valeriocos force-pushed the support-search-terms branch 2 times, most recently from 5175bb4 to 32d2ffd Compare March 31, 2020 12:22
@valeriocos valeriocos changed the title [ELK] Change raw mappings to support search terms [ELK] Change raw mappings to support search fields Mar 31, 2020
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
   {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
        }
     }
   }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
       {
         "dynamic":true,
         "properties": {
            "data": {
               "dynamic":false,
               "properties": {}
            }
         }
       }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
     {
         "dynamic":true,
         "properties": {
            "data": {
               "dynamic":false,
               "properties": {}
            }
         }
     }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
     {
            "dynamic":true,
            "properties": {
            "data": {
               "dynamic":false,
               "properties": {}
            }
         }
     }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
     {
            "dynamic":true,
            "properties": {
            "data": {
               "dynamic":false,
               "properties": {}
            }
        }
     }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
     {
           "dynamic":true,
           "properties": {
              "data": {
                 "dynamic":false,
                 "properties": {}
               }
           }
    }
    ```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
     {
           "dynamic":true,
           "properties": {
            "data": {
               "dynamic":false,
               "properties": {}
            }
         }
     }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
      {
            "dynamic":true,
            "properties": {
                "data": {
                "dynamic":false,
                "properties": {}
            }
          }
      }
    ```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
          {
                "dynamic":true,
                "properties": {
                    "data": {
                    "dynamic":false,
                    "properties": {}
                }
              }
          }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
          {
                "dynamic":true,
                "properties": {
                    "data": {
                    "dynamic":false,
                    "properties": {}
                }
              }
          }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
          {
                "dynamic":true,
                "properties": {
                    "data": {
                    "dynamic":false,
                    "properties": {}
                }
              }
          }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
          {
                "dynamic":true,
                "properties": {
                    "data": {
                    "dynamic":false,
                    "properties": {}
                }
              }
          }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
          {
                "dynamic":true,
                "properties": {
                    "data": {
                    "dynamic":false,
                    "properties": {}
                }
              }
          }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
          {
                "dynamic":true,
                "properties": {
                    "data": {
                    "dynamic":false,
                    "properties": {}
                }
              }
          }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
          {
                "dynamic":true,
                "properties": {
                    "data": {
                    "dynamic":false,
                    "properties": {}
                }
              }
          }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
          {
                "dynamic":true,
                "properties": {
                    "data": {
                    "dynamic":false,
                    "properties": {}
                }
              }
          }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
          {
                "dynamic":true,
                "properties": {
                    "data": {
                    "dynamic":false,
                    "properties": {}
                }
              }
          }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code changes the mapping of the raw items.
The new mapping is the following:
```
    {
     "dynamic":true,
     "properties": {
        "data": {
           "dynamic":false,
           "properties": {}
       }
      }
    }
```

Signed-off-by: Valerio Cosentino <[email protected]>
This code updates the expected results of the test
test_all_properties. This change is needed to match
the new mappings, which doesn't index the `data`
attribute.

Signed-off-by: Valerio Cosentino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants