Fix ::set-output deprecation messages #127

andros21 · 2023-11-14T14:36:42Z

No description provided.

inteon · 2023-11-20T12:32:08Z

scan-apk/action.yaml

@@ -70,7 +70,7 @@ runs:
        tag: localhost:1234/apk-scan

    - id: grype-scan
-      uses: anchore/scan-action@ecfd0e98932e57ea8f68f29c4f418fc41a8194db
+      uses: anchore/scan-action@24fd7c9060f3c96848dd1929fac8d796fb5ae4b4


This change seems unrelated to the rest of the PR?

Yes, it seems unrelated but without this minor bump v3.2.5 -> v3.3.6 not all ::set-ouput warnings go away, because used inside actual pinned version of anchore/scan-action. Maybe a different version can be selected, I have chosen this cause it's the last one released and surely in there ::set-output warnings are fixed

Let me know if you prefer to remove this change and bumps it in a separated PR or if ok, I have to cite the reason behind this bump briefly in the commit msg

inteon · 2023-11-20T14:06:21Z

@imjasonh anyone on the chainguard team who is available to review and merge this PR?

cpanato

thanks for the updates
a small nit

cpanato · 2023-11-20T14:08:04Z

scan-apk/action.yaml

@@ -70,7 +70,7 @@ runs:
        tag: localhost:1234/apk-scan

    - id: grype-scan
-      uses: anchore/scan-action@ecfd0e98932e57ea8f68f29c4f418fc41a8194db
+      uses: anchore/scan-action@24fd7c9060f3c96848dd1929fac8d796fb5ae4b4


can you add the version tag that this git hash is pointing to? will make easier for the next time

Sure, added

inteon · 2024-01-17T08:46:10Z

@cpanato The PR now seems to be ready.

cpanato · 2024-01-22T11:20:45Z

apko-publish/action.yaml

@@ -135,10 +135,12 @@ runs:
        --network host \
        -v $PWD:${{ github.workspace }} \
        -v /tmp:/tmp \
+        -v $GITHUB_OUTPUT:$GITHUB_OUTPUT \


looking at it again, is this required?

cpanato · 2024-01-22T11:20:58Z

apko-publish/action.yaml

        --workdir ${{ github.workspace }} \
        -e "GITHUB_ACTOR=${{ inputs.repository_owner }}" \
        -e "GITHUB_TOKEN=${{ inputs.token }}" \
        -e "REPOSITORY=${{ inputs.repository }}" \
+        -e "GITHUB_OUTPUT=$GITHUB_OUTPUT" \


Not strictly required, both are required if digest output (line 180) is done inside the docker run command. An alternative way could be something like this andros21@1597f1f. If ok, I can update it

i think you can remove this

cpanato · 2024-05-28T11:45:46Z

apko-publish/action.yaml

        --workdir ${{ github.workspace }} \
        -e "GITHUB_ACTOR=${{ inputs.repository_owner }}" \
        -e "GITHUB_TOKEN=${{ inputs.token }}" \
        -e "REPOSITORY=${{ inputs.repository }}" \
+        -e "GITHUB_OUTPUT=$GITHUB_OUTPUT" \


i think you can remove this

Signed-off-by: andros21 <[email protected]>

@andros21

- kudos to @andros21 for the fix in chainguard-images#127 - fixes chainguard-images#140 ``` The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` Co-authored-by: andros21 <[email protected]>

@andros21

- kudos to @andros21 for the fix in chainguard-images#127 - fixes chainguard-images#140 ``` The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` Co-authored-by: andros21 <[email protected]> Co-authored-by: neumayr <[email protected]>

@andros21

- kudos to @andros21 for the fix in chainguard-images#127 - fixes chainguard-images#140 ``` The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` Signed-off-by: neumayr <[email protected]> Co-authored-by: andros21 <[email protected]>

@andros21

- kudos to @andros21 for the fix in chainguard-images#127 - fixes chainguard-images#140 ``` The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` Signed-off-by: neumayr <[email protected]> Co-authored-by: andros21 <[email protected]>

@andros21

- kudos to @andros21 for the fix in chainguard-images#127 - fixes chainguard-images#140 ``` The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` Signed-off-by: neumayr <[email protected]> Co-authored-by: andros21 <[email protected]>

@andros21

- kudos to @andros21 for the fix in chainguard-images#127 - fixes chainguard-images#140 ``` The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` Signed-off-by: neumayr <[email protected]> Co-authored-by: andros21 <[email protected]>

@andros21

- kudos to @andros21 for the fix in chainguard-images#127 - isolate commit ``` The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` Signed-off-by: neumayr <[email protected]> Co-authored-by: andros21 <[email protected]>

@andros21

- kudos to @andros21 for the fix in chainguard-images#127 - isolate commit ``` The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` Signed-off-by: neumayr <[email protected]> Co-authored-by: andros21 <[email protected]>

@andros21

- kudos to @andros21 for the fix in chainguard-images#127 - isolate commit ``` The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ ``` Signed-off-by: neumayr <[email protected]> Co-authored-by: andros21 <[email protected]>

neumayr · 2024-12-10T14:04:26Z

Hi @cpanato, @andros21 and @imjasonh – I hope you're having a great day – I just wanted to check if we could be a little supportive of each other and get this silly deprecation message out of the way. Thanks in advance! 🌻

inteon reviewed Nov 20, 2023

View reviewed changes

cpanato requested changes Nov 20, 2023

View reviewed changes

andros21 force-pushed the set-output branch from 1566240 to d1e6496 Compare November 20, 2023 14:14

cpanato approved these changes Jan 17, 2024

View reviewed changes

cpanato requested a review from imjasonh January 17, 2024 12:10

cpanato reviewed Jan 22, 2024

View reviewed changes

cpanato requested changes May 28, 2024

View reviewed changes

andros21 force-pushed the set-output branch from d1e6496 to 1c9122b Compare June 2, 2024 15:47

Fix ::set-output deprecation messages

a83785a

Signed-off-by: andros21 <[email protected]>

andros21 force-pushed the set-output branch from 1c9122b to a83785a Compare June 2, 2024 16:04

neumayr mentioned this pull request Aug 1, 2024

fix set-output deprecation messages in apko-publish #148

Closed

neumayr mentioned this pull request Aug 2, 2024

fix set-output deprecation messages in scan-apk #152

Closed

neumayr mentioned this pull request Aug 2, 2024

fix set-output deprecation messages in release-monitoring #153

Closed

neumayr mentioned this pull request Aug 2, 2024

fix set-output deprecation messages in vul-scans #154

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ::set-output deprecation messages #127

Fix ::set-output deprecation messages #127

andros21 commented Nov 14, 2023

inteon Nov 20, 2023 •

edited

Loading

andros21 Nov 20, 2023 •

edited

Loading

inteon commented Nov 20, 2023

cpanato left a comment

cpanato Nov 20, 2023

andros21 Nov 20, 2023

inteon commented Jan 17, 2024

cpanato Jan 22, 2024

cpanato Jan 22, 2024

andros21 Jan 22, 2024 •

edited

Loading

cpanato May 28, 2024

cpanato May 28, 2024

neumayr commented Dec 10, 2024

Fix ::set-output deprecation messages #127

Are you sure you want to change the base?

Fix ::set-output deprecation messages #127

Conversation

andros21 commented Nov 14, 2023

inteon Nov 20, 2023 • edited Loading

Choose a reason for hiding this comment

andros21 Nov 20, 2023 • edited Loading

Choose a reason for hiding this comment

inteon commented Nov 20, 2023

cpanato left a comment

Choose a reason for hiding this comment

cpanato Nov 20, 2023

Choose a reason for hiding this comment

andros21 Nov 20, 2023

Choose a reason for hiding this comment

inteon commented Jan 17, 2024

cpanato Jan 22, 2024

Choose a reason for hiding this comment

cpanato Jan 22, 2024

Choose a reason for hiding this comment

andros21 Jan 22, 2024 • edited Loading

Choose a reason for hiding this comment

cpanato May 28, 2024

Choose a reason for hiding this comment

cpanato May 28, 2024

Choose a reason for hiding this comment

neumayr commented Dec 10, 2024

inteon Nov 20, 2023 •

edited

Loading

andros21 Nov 20, 2023 •

edited

Loading

andros21 Jan 22, 2024 •

edited

Loading