-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All examples rendering correctly with vedo 2023.5.0 #281
Conversation
…ebra fish atlas marked as slow and local
…scene.py::test_screenshot
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mega-fix #281 +/- ##
============================================
+ Coverage 81.15% 86.39% +5.23%
============================================
Files 26 26
Lines 1194 1205 +11
============================================
+ Hits 969 1041 +72
+ Misses 225 164 -61 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Needs some very minor fixes 🎉
I hacked something together locally to pytest test/test_examples.py --runslow --runlocal
pass, the minor fixes needed are:
- uncommenting
neurons
andruler
examples intest_examples.py
andexamples/__init__.py
(pushed this commit already) - fixing some relative paths to the data
For now (until we decide to use pooch
) I suggest moving the example data into a resources folder and using importlib.resources
to access it, to avoid duplication of data and problems with relative paths to data files.
For an example use of importlib.resources
see https://github.com/brainglobe/brainrender-napari/blob/2249ba8914ba9ccdef43837d2a6401db657b32e2/brainrender_napari/utils/brainglobe_logo.py#L5
…r/resources, importlib.resources now used to fetch data
All done! All resources are now in |
Before submitting a pull request (PR), please read the contributing guide.
Description
What is this PR
Why is this PR needed?
Several example files were either not running, or not rendering correctly (misaligned with the root mesh)
What does this PR do?
Ensure all example scripts (except streamlines.py due to missing data) run and render correctly.
References
closes #251
closes #261
Checklist: