Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for test_ruler_from_surface, removed transformation #262

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

IgorTatarnikov
Copy link
Member

@IgorTatarnikov IgorTatarnikov commented Oct 30, 2023

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Fix the test_ruler.py::test_ruler_from_surface.

What does this PR do?
Update the API calls to vedo for intersectWithLine(). Removing the Mesh::apply_transform call to meshes in render,py fixes the test and also allows most examples to render correctly (without weird transpositions - cells outside of the brain region, etc...).

References

Closes #255

How has this PR been tested?

Tested locally, all non-slow tests pass!

Is this a breaking change?

No

Checklist:

  • The code has been tested locally
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (mega-fix@3cf712a). Click here to learn what that means.

Additional details and impacted files
@@             Coverage Diff             @@
##             mega-fix     #262   +/-   ##
===========================================
  Coverage            ?   67.86%           
===========================================
  Files               ?       26           
  Lines               ?     1195           
  Branches            ?        0           
===========================================
  Hits                ?      811           
  Misses              ?      384           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder merged commit f638888 into mega-fix Oct 30, 2023
17 of 21 checks passed
@alessandrofelder alessandrofelder deleted the test_ruler_from_surface-bug-fix branch October 30, 2023 11:23
@alessandrofelder alessandrofelder mentioned this pull request Dec 1, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants