Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a cropping+padding utility function #32

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

We'd like functionality to crop images to the brain mask before running affine and non-linear transformations, to improve computational efficiency.

What does this PR do?

Adds a utility function for this purpose

References

\

How has this PR been tested?

Tests have been added.

Is this a breaking change?

Nope.

Does this PR require an update to the documentation?

No.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just had some minor comments on the docstring formatting.

brainglobe_template_builder/preproc/cropping.py Outdated Show resolved Hide resolved
brainglobe_template_builder/preproc/cropping.py Outdated Show resolved Hide resolved
@alessandrofelder alessandrofelder merged commit afe54b1 into main Aug 20, 2024
23 checks passed
@alessandrofelder alessandrofelder deleted the add-cropping-util branch August 20, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants