Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark brainreg-segment package as deprecated in prep for renaming. #140

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

willGraham01
Copy link
Contributor

@willGraham01 willGraham01 commented Nov 1, 2023

Marks brainreg-segment as deprecated, as per brainglobe/BrainGlobe#36.

Once merged:

@willGraham01 willGraham01 requested a review from a team November 1, 2023 11:39
@willGraham01 willGraham01 marked this pull request as ready for review November 1, 2023 11:39
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adamltyson
Copy link
Member

Have I missed something with this PR? Once the package is renamed, it will tell users that it's deprecated, and then link to itself?

@adamltyson
Copy link
Member

I think I did miss something, sorry! I didn't get the #140 then #139 idea. @willGraham01 10 steps ahead of me as usual!

@willGraham01 willGraham01 merged commit 04bc1a2 into main Nov 6, 2023
11 checks passed
@willGraham01 willGraham01 deleted the mark-as-deprecated branch November 6, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants