-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hemisphere improvements to axolotl atlas #438
Conversation
Do we need this? The whole point of the hemispheres stack is so that we don't have seperate regions for L & R. |
We need this for PinPoint (#437), which requires unique acronyms. The alternative would be to merge annotation regions in the atlas, but would mean deviating from the original data? |
All our other atlases have the same region (and acronym) in L & R hemispheres. The hemisphere is then encoded by the image. Does this atlas have different numerical IDs in each hemisphere? If so, this is what should be corrected to meet the BrainGlobe spec. |
Yep, it does.
OK! |
I guess this should be added to the list of things that need to be documented 😞 |
I've addressed the comments, and think this is ready now :) |
Description
What is this PR
Why is this PR needed?
The UNAM axolotl atlas is asymmetric and has duplicate region acronyms (because the same region exists in each hemisphere)
What does this PR do?
References
First tickbox of #359
Closes #437
How has this PR been tested?
Visual inspection and validation script on local axolotl atlas.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No