don't rerun tests on README updates #405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently the tests rerun on all pushes. Even if that push was just to update the README.
|
I would err on the side of keeping the current behaviour. Currently our tests don't include any text linting, but they may do in the future. We also have 100+ repos to maintain, so I like to keep them as similar as possible :) Happy to be overruled though. Any thoughts @brainglobe/active-devs? |
|
no problem. Happy to close this pull request then! |
|
Thanks @PolarBean. I will close this now, but it may be an idea we come back to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the tests rerun on all pushes. Even if that push was just to update the README.
very minor change, it just bugged me seeing the tests always rerun on readme changes :)