Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atlas packaging template #400
Atlas packaging template #400
Changes from 12 commits
fcb1bf9
6dc6052
37a75fb
193a78b
cd9bafe
d96ed9d
2254886
813b251
c521a2f
602dbef
f4b0452
9009dc2
1383b14
2b0d42e
c47ca80
262a07c
c51231c
fca9c7b
8052298
91c09f7
3ebdbd4
6cc3222
73387c0
23b3a16
4740c06
f6253e0
af0f450
91b97c8
d9bc6e3
2ee5c7b
1e68bed
924e484
d643653
78fe6d5
642e0bb
536281f
df352c3
c15a449
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand this: is this information we should include to help people running this script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in people will use this script to package their own atlases. We should explain how to handle particular edge cases they may run into. for example what if the atlas is not hierarchical? Do we then just say treat everything having a structure_id_path of brain, region? or what if their atlas doesnt have RGB colours assigned to each region, is it then acceptable for them to randomly generate colours? I think the template should either explain these cases or point to a resource that does.