Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite editor navigation model #1870

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

glopesdev
Copy link
Member

@glopesdev glopesdev commented Jul 2, 2024

  • Add workflow explorer treeview
  • Allow navigating to any level without opening previous levels
  • Allow visualizers to run uncoupled from the workflow view
  • Highlight build errors in explorer treeview

Fixes #1823
Fixes #1993
Fixes #2000
Fixes #2001
Fixes #2004

@glopesdev glopesdev added feature New planned feature proposal Request for a new feature labels Jul 2, 2024
@glopesdev glopesdev added this to the 2.9 milestone Jul 2, 2024
@glopesdev glopesdev force-pushed the issue-1823 branch 2 times, most recently from b02e6ba to 8a1b9af Compare July 16, 2024 08:38
@glopesdev glopesdev marked this pull request as ready for review September 3, 2024 18:02
@glopesdev
Copy link
Member Author

glopesdev commented Sep 5, 2024

Early feedback from the preview is that allowing opening of independent tabs and windows should be allowed in the editor control to allow watching different parts of the workflow.

We could take this opportunity to generalize tabs and floating windows into a single dock panel. The main concern is going to be how to handle multiple windows pointing to the same path, and what to do when deleting group nodes causes invalidation of multiple open tabs.

For the first issue we could consider enforcing that windows are singleton w.r.t. a unique path, which would obviate having to synchronize multiple view states of the same workflow.

For the second issue we could probably store it in the undo/redo stack as we did in the previous navigation model by closing as a command and scheduling reopening of tab/window pointing to the deleted path with same settings in the undo command. Another option is to restrict navigation to only one window and have secondary windows used only as read-only or watch views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment