Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14380] Add GET /tasks/organization endpoint #5149

Open
wants to merge 4 commits into
base: vault/pm-14378/security-task-auth-handler
Choose a base branch
from

Conversation

shane-melton
Copy link
Member

@shane-melton shane-melton commented Dec 13, 2024

🎟️ Tracking

PM-14380

📔 Objective

Add the new GET /tasks/organization?organizationId=XXX&status=0 endpoint to the SecurityTasksController and the corresponding queries and sprocs.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 33.92857% with 37 lines in your changes missing coverage. Please review.

Project coverage is 42.96%. Comparing base (b10df9b) to head (0b9a2cd).

Files with missing lines Patch % Lines
...ework/Vault/Repositories/SecurityTaskRepository.cs 0.00% 22 Missing ⚠️
...apper/Vault/Repositories/SecurityTaskRepository.cs 0.00% 8 Missing ⚠️
...rc/Api/Vault/Controllers/SecurityTaskController.cs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                              Coverage Diff                              @@
##           vault/pm-14378/security-task-auth-handler    #5149      +/-   ##
=============================================================================
- Coverage                                      43.02%   42.96%   -0.06%     
=============================================================================
  Files                                           1450     1451       +1     
  Lines                                          66369    66409      +40     
  Branches                                        6086     6087       +1     
=============================================================================
- Hits                                           28553    28534      -19     
- Misses                                         36524    36583      +59     
  Partials                                        1292     1292              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Logo
Checkmarx One – Scan Summary & Details63efdf23-de54-44e0-b856-f461be95a8ec

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 70 Attack Vector
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationsController.cs: 52 Attack Vector
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38 Attack Vector
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 91 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 66
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/DomainClaimedByOrganization.html.hbs: 5

Copy link
Member

@gbubemismith gbubemismith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shane-melton shane-melton force-pushed the vault/pm-14380/list-organization-tasks-endpoint branch from ed9c14d to 0b9a2cd Compare December 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants