-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MsSqlMigratorUtility run configuration for VS Code #5135
base: main
Are you sure you want to change the base?
Add MsSqlMigratorUtility run configuration for VS Code #5135
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5135 +/- ##
==========================================
- Coverage 42.93% 42.90% -0.03%
==========================================
Files 1433 1435 +2
Lines 65660 65705 +45
Branches 6020 6030 +10
==========================================
+ Hits 28190 28191 +1
- Misses 36205 36247 +42
- Partials 1265 1267 +2 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
"request": "launch", | ||
"program": "${workspaceFolder}/util/MsSqlMigratorUtility/bin/Debug/net8.0/MsSqlMigratorUtility.dll", | ||
"args": [ | ||
"Server=localhost;Database=vault_dev;User Id=SA;Password=SET_A_PASSWORD_HERE_123;Encrypt=True;TrustServerCertificate=True;" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev/
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I composed a connection string based on the default .env file values. I think it's better to execute the utility as close to the actual usage as possible to test it in a real scenario and avoid maintaining additional code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but how could the user of this launcher use this without modifying the args
? Maybe I am missing something but we can't have to ask users to modify this file to get this to run.
.vscode/tasks.json
Outdated
"/property:GenerateFullPaths=true", | ||
"/consoleloggerparameters:NoSummary" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Are these used specifically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I just copied those from other build tasks.
Co-authored-by: Matt Bishop <[email protected]>
🎟️ Tracking
📔 Objective
Add build and run configuration for MsSqlMigratorUtility for VS Code.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes