Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MsSqlMigratorUtility run configuration for VS Code #5135

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

michalchecinski
Copy link
Contributor

🎟️ Tracking

📔 Objective

Add build and run configuration for MsSqlMigratorUtility for VS Code.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.90%. Comparing base (9e86010) to head (0f253ae).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5135      +/-   ##
==========================================
- Coverage   42.93%   42.90%   -0.03%     
==========================================
  Files        1433     1435       +2     
  Lines       65660    65705      +45     
  Branches     6020     6030      +10     
==========================================
+ Hits        28190    28191       +1     
- Misses      36205    36247      +42     
- Partials     1265     1267       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Logo
Checkmarx One – Scan Summary & Detailsc88a0ce0-865d-48ce-aad1-58353a4cf9bc

No New Or Fixed Issues Found

.vscode/launch.json Outdated Show resolved Hide resolved
"request": "launch",
"program": "${workspaceFolder}/util/MsSqlMigratorUtility/bin/Debug/net8.0/MsSqlMigratorUtility.dll",
"args": [
"Server=localhost;Database=vault_dev;User Id=SA;Password=SET_A_PASSWORD_HERE_123;Encrypt=True;TrustServerCertificate=True;"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This password would need to change though, and couldn't be maintained here ... the utility has to be able to read the user secrets in dev/.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I composed a connection string based on the default .env file values. I think it's better to execute the utility as close to the actual usage as possible to test it in a real scenario and avoid maintaining additional code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but how could the user of this launcher use this without modifying the args? Maybe I am missing something but we can't have to ask users to modify this file to get this to run.

Comment on lines 263 to 264
"/property:GenerateFullPaths=true",
"/consoleloggerparameters:NoSummary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Are these used specifically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I just copied those from other build tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants