Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14461] Return ProfileOrganizationResponse from subscription update #5103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amorask-bitwarden
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden commented Dec 3, 2024

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-14461

๐Ÿ“” Objective

This PR returns the ProfileOrganizationResponseModel after a subscription update that will be consumed by the client for the purpose of refreshing the organization state.

Clients PR: bitwarden/clients#12222

๐Ÿ“ธ Screenshots

Screen.Recording.2024-12-03.at.12.41.58.PM.mov

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 156f627b-1ff0-42a3-9f1c-26e047b41ed7

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.16%. Comparing base (059e681) to head (8fa1dbc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Api/Billing/Controllers/OrganizationsController.cs 83.33% 2 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5103   +/-   ##
=======================================
  Coverage   43.16%   43.16%           
=======================================
  Files        1424     1424           
  Lines       65110    65117    +7     
  Branches     5968     5968           
=======================================
+ Hits        28102    28107    +5     
- Misses      35755    35757    +2     
  Partials     1253     1253           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants