Fix version pins

[nanglo123]

This PR fixes a bug where VERSION_PINS is always set to an empty dictionary due to a misaligned indent. We also handle invalid prefixes and version datatypes more gracefully and make the logger more informative.

[cthoyt]

please lets get 100% unit tests on this code (including the last PR that introduced this), since I think it will be very hard to understand in the future

[nanglo123]

please lets get 100% unit tests on this code (including the last PR that introduced this), since I think it will be very hard to understand in the future

I added some unit tests. Please let me know if any other tests could be added to increase coverage.

[cthoyt]

@nanglo123 you'll need to mock the environment variables for these tests to be meaningful. I'd suggest encapsulating all of the logic that handles the environment variable in a function so you can test it separately

[nanglo123]

@nanglo123 you'll need to mock the environment variables for these tests to be meaningful. I'd suggest encapsulating all of the logic that handles the environment variable in a function so you can test it separately

@cthoyt Are these changes more in line with what you expect? Let me know if anything could be improved.

[nanglo123]

@cthoyt Let me know if anything else could be improved.

[cthoyt]

@nanglo123 please get 100% test coverage for your changes

[nanglo123]

@cthoyt Sorry I forgot to do that before. Let me know if anything else can be improved.

[cthoyt]

thanks @nanglo123 for the updates!