Support bem-xjst 8.x #2010
Merged
Support bem-xjst 8.x #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Ready to merge? |
qfox
reviewed
Mar 7, 2017
| @@ -62,16 +62,19 @@ module.exports = { | |||
| 'applyCtx', | |||
| 'applyNext', | |||
| 'attrs', | |||
| 'addAttrs', | |||
| 'bem', | |||
| 'block', | |||
| 'cls', | |||
| 'content', | |||
qfox
reviewed
Mar 7, 2017
| 'local', | ||
| 'match', | ||
| 'mix', | ||
| 'addMix', | ||
| 'mod', | ||
| 'mode', | ||
| 'tag', |
There was a problem hiding this comment.
Guess we should drop once and extend probably.
qfox
reviewed
Mar 7, 2017
common.blocks/menu/menu.bemhtml.js
Outdated
| @@ -46,10 +46,12 @@ block('menu')( | |||
| attrs['aria-disabled'] = 'true' : | |||
| attrs.tabindex = 0; | |||
|
|
|||
| return attrs; | |||
| // extend in backwards order: | |||
| // bemjson have more priority | |||
tadatuta
force-pushed
the
issues/1942@v6
branch
from
b75be6a to
b3c8ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1942
Cherry-pick of #1996 by @miripiruni
Showcase is available