Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added types #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added types #96

wants to merge 1 commit into from

Conversation

phatpaul
Copy link

I added type defs for static code checking in vscode.
I'm not sure how to tell it that it clobbers cordova.plugins.zeroconf, so I had to add this to my code:

/**@type {?ZeroConfPlugin.ZeroConf} */
let zeroconf = window.cordova && cordova.plugins.zeroconf;

@emcniece
Copy link
Collaborator

emcniece commented Dec 6, 2022

👋 Hi, thanks for the PR!

I noticed that cordova-plugin-add-swift-support has been removed. Is that safe to do for all platforms and supported versions? There's a description of what this plugin does over here - is this support provided somewhere else?

@phatpaul
Copy link
Author

phatpaul commented Dec 7, 2022

Sorry I didn't mean to update this PR with that change. I'll try to fix this PR so it doesn't include it.

Anyway, that plugin cordova-plugin-add-swift-support breaks my build on Android, so I removed it. I assumed that the swift support must have been integrated into cordova core by now. No? I'm about to test it on iOS...

EDIT: this PR akofman/cordova-plugin-add-swift-support#78 to the swift pluigin would fix my Android problems, but the maintainer hasn't merged any PRs in 4 years. FYI: akofman/cordova-plugin-add-swift-support#76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants