Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove depenency on swift plugin #102

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

phatpaul
Copy link

@phatpaul phatpaul commented Dec 7, 2022

see #101

I tested this and it works on iOS. I don't think it should affect Android at all, but I'll check it.

But I did get the error
error: Value for SWIFT_VERSION cannot be empty. but then I manually set the Swift Version in XCode and it worked. Not sure why <preference name="SwiftVersion" value="4.0" /> is not taking effect. Maybe a bug in cordova?

@emcniece emcniece self-requested a review December 7, 2022 21:46
@emcniece
Copy link
Collaborator

emcniece commented Dec 8, 2022

Possibly this? https://forum.ionicframework.com/t/ios-build-issue-value-for-swift-version-cannot-be-empty/186855/3

<preference name="UseSwiftLanguageVersion" value="4" />

@phatpaul
Copy link
Author

Well, it worked fine this time I did a fresh build from scratch. If it works for you too then I'd say it's good.

It looks like UseSwiftLanguageVersion was just for the old plugin cordova-plugin-add-swift-support. The cordova-ios native feature uses SwiftVersion.

Here's an example of another plugin that did this same thing:
https://github.com/NiklasMerz/cordova-plugin-fingerprint-aio/pull/279/files

BTW, there's some chance of conflicting swift versions with workaround described here:
NiklasMerz/cordova-plugin-fingerprint-aio#342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants