Remove dead assignments #492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dead assignments are a programming error of some sort, but removing the assignment in a way which preserves behaviour may preserve whatever error was made at the same time as eliminating a warning. For example: 733801c#diff-0b6fc2b9b7368823d9b36f7307ebaab80552c906effb06812f796aa9c25cec73 it is not obvious that removing the first assignment is better than removing the second one. IMO, these should be investigated rather than simply removed. Or, submit fixes for those which are obviously correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some minor dead assignments and initializations detected by static analyzer.