Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ-69233: backport to 2.4.x #469

Open
wants to merge 3 commits into
base: 2.4.x
Choose a base branch
from
Open

BZ-69233: backport to 2.4.x #469

wants to merge 3 commits into from

Conversation

ylavic
Copy link
Member

@ylavic ylavic commented Aug 1, 2024 •
edited
Loading

  • r1912462
  • r1919617
  • r1919619

covener
covener reviewed Aug 1, 2024
View reviewed changes
include/ap_mmn.h Outdated Show resolved Hide resolved
ylavic added 3 commits August 1, 2024 14:48
@ylavic
mod_proxy: Simplify ap_proxy_get_worker_ex()
660853c 
Factorize duplicated code in the balancer and non-balancer cases by adding
a new worker_matches() helper.

No functional change intended.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1912462 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
mod_proxy: Fix selection of ProxyPassMatch workers with host/port sub…
069d706 
…stitution. PR 69233.

With "ProxyPassMatch ^/([^/]+)/(.*)$ https://$1/$2", ap_proxy_get_worker_ex()
should not consider the length of scheme://host part of the given URL because
of the globbing match on the host part.

Fix it by setting worker->s>is_host_matchable when creating a worker with host
substitution and avoiding the min_match check in worker_matches() in this case.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1919617 13f79535-47bb-0310-9956-ffa450edef68
@ylavic
Follow up to r1919617: Better CHANGES entry per Eric.
00cd80e 
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1919619 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@covener covener covener left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ylavic @covener