-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): image + video quality, disable saving to camera roll/photo album, image scaling #46
base: master
Are you sure you want to change the base?
Conversation
abilio-henrique
commented
Sep 17, 2015
- Added image and video quality options for iOS
- Added option to disable saving photos to camera roll/photo album
- Added image scaling options
…o be consistent with Cordova's official camera plugin.
|
||
// Set quality of captured video | ||
if (quality) { | ||
if ([quality intValue] == 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it should be zero here.
Is this ever getting merged? My project specifically needs to be able to set whether the photo is saved to the photo album, and this PR seems good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard conflict (unsurprisingly after so long), but the changes look interesting and good - so it might be worth to create new PRs based on master
that add the individual features one by one.