fix(android): handle cancelled media capture intent (#291) #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you consider this PR to be still relevant? after your comment and sort of resolution through |
|
Still relevant for apps that uses |
ath0mas
reviewed
Jun 25, 2024
| // Result received okay | ||
| if (resultCode == Activity.RESULT_OK) { | ||
| // Result received okay or the capture image intent has been cancelled | ||
| if (resultCode == Activity.RESULT_OK || (req.action == CAPTURE_IMAGE && intent == null)) { |
There was a problem hiding this comment.
Why specifically CAPTURE_IMAGE? It may be the case for audio and video capture too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Fixes the #291 issue.
Description
In case of a cancelled image capture intent we
onImageActivityResultanyway and check there if the writen image size is greater than 0.This handle the case where the intent is cancelled but the image is available.
Testing
Can someone explain how to run the tests?
Checklist
(platform)if this change only applies to one platform (e.g.(android))