Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check to find if common.compat provider is changed in a non-compatible way #44913

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+233 −13
Draft

add check to find if common.compat provider is changed in a non-compatible way #44913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,13 @@ repos:
exclude: ^airflow/kubernetes/
entry: ./scripts/ci/pre_commit/check_airflow_k8s_not_used.py
additional_dependencies: ['rich>=12.4.4']
- id: check-common-compat-compatibility
name: Check if compat is changed in a non-compatible way
language: python
files: ^providers/src/airflow/providers/common/compat/.*\.py$
require_serial: true
entry: ./scripts/ci/pre_commit/check_common_compat_compatibility.py
additional_dependencies: ['rich>=12.4.4']
- id: check-common-compat-used-for-openlineage
name: Check common.compat is used for OL deprecated classes
language: python
Expand Down
2 changes: 2 additions & 0 deletions contributing-docs/08_static_code_checks.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ require Breeze Docker image to be built locally.
+-----------------------------------------------------------+--------------------------------------------------------+---------+
| check-code-deprecations | Check deprecations categories in decorators | |
+-----------------------------------------------------------+--------------------------------------------------------+---------+
| check-common-compat-compatibility | Check if compat is changed in a non-compatible way | |
+-----------------------------------------------------------+--------------------------------------------------------+---------+
| check-common-compat-used-for-openlineage | Check common.compat is used for OL deprecated classes | |
+-----------------------------------------------------------+--------------------------------------------------------+---------+
| check-core-deprecation-classes | Verify usage of Airflow deprecation classes in core | |
Expand Down
Loading
Loading