Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): nb_api_calls in getLogs response is optional #4142

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Nov 22, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3228

Changes included:

closes #4139

this parameter isn't required in the response, I also checked previous major versions and it was already optional

@shortcuts shortcuts self-assigned this Nov 22, 2024
@shortcuts shortcuts requested a review from a team as a code owner November 22, 2024 11:10
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 22, 2024

✔️ Code generated!

Name Link
🪓 Triggered by e2b7e934eba1a7221644084093d679bc61309c2b
🍃 Generated commit 3f7620c6e53d3a08143b1012ac2b19f87fa3751a
🌲 Generated branch generated/fix/search-logs-endpoint
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1627
javascript 1623
php 1484
csharp 1389
java 1125
python 1101
ruby 835
swift 765

@shortcuts shortcuts merged commit 9e02356 into main Nov 22, 2024
57 checks passed
@shortcuts shortcuts deleted the fix/search-logs-endpoint branch November 22, 2024 13:15
algolia-bot added a commit that referenced this pull request Nov 22, 2024
…(generated) [skip ci]

Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Nov 22, 2024
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Nov 22, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Nov 22, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Nov 22, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Nov 22, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Nov 22, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Nov 22, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Nov 22, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Nov 22, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Nov 22, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Serialization error using the get-logs API
3 participants