Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codspeed benchmarks #1029

Closed
wants to merge 6 commits into from
Closed

Add codspeed benchmarks #1029

wants to merge 6 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 16, 2024

We are planning on merging free-threading support in #1015 but have no good way to test this does not regress performance. Add benchmarks ahead of merge so we can get a test in the CI

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 16, 2024
tests/test_multidict_benchmarks.py Fixed Show fixed Hide fixed
tests/test_multidict_benchmarks.py Fixed Show fixed Hide fixed
tests/test_multidict_benchmarks.py Fixed Show fixed Hide fixed
@bdraco bdraco closed this Oct 16, 2024
@bdraco bdraco reopened this Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.86%. Comparing base (88ac22c) to head (938512a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
+ Coverage   94.30%   94.86%   +0.55%     
==========================================
  Files          22       23       +1     
  Lines        2425     2686     +261     
  Branches      227      254      +27     
==========================================
+ Hits         2287     2548     +261     
  Misses         67       67              
  Partials       71       71              
Flag Coverage Δ
CI-GHA 94.86% <100.00%> (+0.55%) ⬆️
MyPy 67.51% <70.49%> (+0.32%) ⬆️
pytest 98.11% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_multidict_benchmarks.py Dismissed Show dismissed Hide dismissed
tests/test_multidict_benchmarks.py Dismissed Show dismissed Hide dismissed
tests/test_multidict_benchmarks.py Dismissed Show dismissed Hide dismissed
Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 38 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_cimultidict_add_istr_performance (81.3 µs)
  • test_cimultidict_add_str_performance (106.4 µs)
  • test_cimultidict_clear_str_performance (14.2 µs)
  • test_cimultidict_delitem_istr_performance (112.3 µs)
  • test_cimultidict_delitem_str_performance (160.8 µs)
  • test_cimultidict_extend_istr_performance (145.6 µs)
  • test_cimultidict_extend_str_performance (184.5 µs)
  • test_cimultidict_fetch_istr_performance (60.3 µs)
  • test_cimultidict_fetch_str_performance (84.7 µs)
  • test_cimultidict_get_hit_performance (117.4 µs)
  • test_cimultidict_get_hit_with_default_performance (124.7 µs)
  • test_cimultidict_get_istr_hit_performance (93.8 µs)
  • test_cimultidict_get_istr_hit_with_default_performance (100.9 µs)
  • test_cimultidict_get_istr_miss_performance (151.8 µs)
  • test_cimultidict_get_istr_with_default_miss_performance (159.2 µs)
  • test_cimultidict_get_miss_performance (176.6 µs)
  • test_cimultidict_get_miss_with_default_performance (185.1 µs)
  • test_cimultidict_getall_istr_hit_performance (33.8 µs)
  • test_cimultidict_getall_str_hit_performance (40.9 µs)
  • test_cimultidict_insert_istr_performance (68.7 µs)
  • test_cimultidict_insert_str_performance (99.9 µs)
  • test_cimultidict_pop_istr_performance (129.9 µs)
  • test_cimultidict_pop_str_performance (177.3 µs)
  • test_cimultidict_popitem_str_performance (98.2 µs)
  • test_cimultidict_update_istr_performance (156.8 µs)
  • test_cimultidict_update_str_performance (184.4 µs)
  • test_multidict_add_str_performance (76.7 µs)
  • test_multidict_clear_str_performance (14.2 µs)
  • test_multidict_delitem_str_performance (103.7 µs)
  • test_multidict_extend_str_performance (185.7 µs)
  • test_multidict_fetch_performance (54.9 µs)
  • test_multidict_get_hit_performance (87.4 µs)
  • test_multidict_get_miss_performance (147.1 µs)
  • test_multidict_getall_str_hit_performance (33 µs)
  • test_multidict_insert_str_performance (70.1 µs)
  • test_multidict_pop_str_performance (120.6 µs)
  • test_multidict_popitem_str_performance (98.1 µs)
  • test_multidict_update_str_performance (151.6 µs)

@bdraco bdraco marked this pull request as ready for review October 17, 2024 00:23
@bdraco
Copy link
Member Author

bdraco commented Oct 17, 2024

RTD build failed for some reason and I can't get it to run so doing another PR #1030

@bdraco bdraco closed this Oct 17, 2024
@bdraco bdraco deleted the benchmarking branch October 17, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant