feat(kubens): added force flag to switch namespaces even if it doesn'… #416
Conversation
idsulik
force-pushed
the
feat-issue-333
branch
from
635dc0e to
fdfa71d
Compare
|
@ahmetb Hi! |
|
Sorry, I mostly haven't gotten around reviewing it |
|
@ahmetb hi! kindly remind you |
README.md
Outdated
| Context "test" set. | ||
| Active namespace is "not-found-namespace". | ||
| --- | ||
| $ kubens not-found-namespace --f |
There was a problem hiding this comment.
Double dash is weird to see for single letter flags. Mistake?
There was a problem hiding this comment.
yes, it's mistake, pushed fix
cmd/kubens/flags.go
Outdated
| force := false | ||
|
|
||
| if n == 2 { | ||
| force = argv[1] == "--force" || argv[1] == "-f" |
There was a problem hiding this comment.
I think slices.Contains is better here? IMO people should be able to do both:
- kubens foo -f
- kubens -f foo
There was a problem hiding this comment.
pushed changes to support both versions
cmd/kubens/flags.go
Outdated
|
|
||
| if n == 2 { | ||
| force = argv[1] == "--force" || argv[1] == "-f" | ||
| } |
There was a problem hiding this comment.
There are some tests of this file, do you mind editing?
|
@ahmetb hi! is there anything else to do within the PR? |
|
Merged it but it seems it failed on master due to Go version and slices pkg being new. |
sorry about that, I fixed it here #425. |
Hello!
Added
--force&&-fflags tokubenscommand to switch namespace even if it doesn't exist.issue: #333
usage example