A bit of care taking on the code itself. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Petsagourakis <[email protected]>
Mostly restructuring the logic statements for clarity and making code logic more shallow. The bug fix is about the Collection.php file around @@180 that had `$this->getCollectionNames()` instead of `$this->database->getCollectionNames()` Signed-off-by: George Petsagourakis <[email protected]>
…intersect_key` function. Signed-off-by: George Petsagourakis <[email protected]>
Signed-off-by: George Petsagourakis <[email protected]>
Introducing throwing `RuntimeException` for `json_decode` errors. Signed-off-by: George Petsagourakis <[email protected]>
…ng composer.lock. The composer .lock is recommended that it is not committed as per Composer guidelines. (see https://getcomposer.org/doc/02-libraries.md#lock-file). Also trying to make the conflict in Collection.php go away.
|
I am trying to find where the conflict is so that I can fix it. Stay with me. It is in line 205 which is correct. I don't see what it conflicts with. |
|
No response to the PR in THREE years and no core commits in TWO years. Looks like project is no longer maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functionality has been altered.
The tests pass.
PHPDoc comments are working better and are more descriptive.
The code's logic is more shallow and thus more clarity.
Fixed a bug as well, see commit messages.