-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for MsLz, added tests for cab, updated net version to 6… #64
base: master
Are you sure you want to change the base?
Conversation
…, added nullable types
epic! do you think we should change target to net6? this will break compatibility with existing projects net3 and net5 |
I asked myself that too. For my projects it is pretty important to make sure that null checks are done properly but I'm also the person who can decided what framework we are using :-) Some examples where nullable helps to stop bugs (non obvious nullable results)
Please let me know what you think. |
well, we can put some |
For me it is:
I agree with the #ifdefs making the code messy. |
Here is the first version of the linux port: https://github.com/kammerjaeger/SevenZipExtractor/tree/LinuxPort
I'm not sure this is bug free yet, did not do any mayor testing outside from the test cases, yet. Also it is net 6. If find any time I may look into if it is possible to use earlier versions. Please let me know if you are even interested in integrating this. |
linux support is a huge step forward! Will give it a try asap! 🚀🚀🚀🎉 |
Some information for linux: |
Did you have time looking at it? I added some improvements and bugfixes to the linux port. I am thinking of adding a function to create new archives and I think it would be better to finish this first. |
…, added nullable types
Changes in this PR:
I have a working linux version, these are the changes that make sense without the complete rework that is needed for linux.
Please let me know what you think.