This repository has been archived by the owner on Mar 30, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling return inside a block under Rubinius results in aLocalJumpError, at least with version 2.3.0. This is probably a Rubinius bug but it is easy enough to work around it here.
I am making the assumption that
accept!
will never return nil. Is that reasonable?Unfortunately one other spec still fails but I don't think it's Squeel's fault. It's something to do with preloading HABTM associations, possibly caused by the Rubinius implementation of flat_map.