-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution: Poster #148
base: master
Are you sure you want to change the base?
Contribution: Poster #148
Conversation
Assets used: - Source Code Pro: (C) Adobe, SIL Open Font License - Nunito Sans: (C) Adobe, SIL Open Font License - GitHub & CC0 Icons: (C) Remix Design, Apache License 2.0, attribution waived
Wow, this is so cool! The rewordings are great. Concise but still carry the original intent well. Few questions:
It would be cool in the future if we could write a little script to derive the SVG from the readme itself, unify the wording and automate regenerating it. Either way I'm happy to include this in the repo as an associated work 🙂 |
The SVG itself is an Inkscape svg, and the original PDF was generated with Inkscape, so I'd assume that there should be a way to do it through the Inkscape command line tool, although it may be easier to just render edits using the Inkscape GUI, since it's likely that that's how any future edits to the poster would be made. If you're really interested though, I can try to figure out the Inkscape command.
That is definitely not intentional. This is what the render is supposed to look like: If I had to guess, that sounds like there might be a problem with embedding or reading the fonts from the PDF. It could be a bug with Preview too, does it look right if you view it in a browser? A few possible solutions:
I'm leaning towards option two, but the call is yours.
That would certainly be very cool, but likely quite difficult. There's a few little tweaks like centring and line height that are easy for a human to make, but might be pretty annoying to automate. I don't think that that's a task I'd be up to myself, although it would be awesome if someone else wanted to take that up! |
Dang what is with that *one spot*
Hmmm still rendering strangely on macOS, but working totally fine in the Github preview now (don't think it was rendering there before). I'll have a look at it in InkScape on my machine after work today, will get back to you later on 👍 |
Hey @Widdershin, I was wondering if you'd had a chance to take a look at this. If you're busy, I totally understand, but I just wanted to make sure it wasn't forgotten |
Hi @Alch-Emi, Thanks for following up! You've not been forgotten, my Dec/Jan was just pretty wild and I didn't have much time for OSS. I'll try to get to this soon :) |
Totally understandable! Thank you so much!
…On Sat, Jan 30, 2021 at 05:24, Nick Johnstone ***@***.***> wrote:
Hi @Alch-Emi <https://github.com/Alch-Emi>,
Thanks for following up! You've not been forgotten, my Dec/Jan was
just pretty wild and I didn't have much time for OSS. I'll try to get
to this soon :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJIYMMMTEWUS7Z2SSNSY7QLS4QCCNANCNFSM4ULCLMSQ>.
|
It looks like you're missing a couple fonts? You should be able to grab them off of Google Fonts though I think. As for the missing numbers, it's a shame that it's still a problem. I wonder if we could convert just the numbers to paths, and leave the text as text? Also, did the fonts show up right in the PDF? |
Sorry I still haven't followed up on this, have been stupid busy.
That sounds like a good idea. Are there any other changes you'd like to make before we merge? I added another tenet just to make life difficult 😅 |
Hey! I found out about this project by chance last night, and I really like what you're doing. I already submitted my signature, but I thought it might be neat if I could contribute something along the lines of a poster to visually display the oath. It's nothing fancy, but I ended up coming up with this poster.
You might notice that there's a couple small changes made to items 2 and 8. In order to fit them into the two line format, I had to shorten them a little bit. Specifically, the parts that I removed are:
and
I tried to remove sections that changed the meaning of the items as little as possible, but due to the concise nature of each item, and the amount that I needed to remove from item 2, the meaning may still have changed a good bit.
If you have any suggestions or feedback, feel free to let me know. Also, don't feel obligated to accept just because I made this, and I wouldn't be hurt if you decided you didn't want it.
This work is, to the greatest extent of my ability, released under CC0. This fact is also mentioned in the metadata of the poster.
Best,
Emi <3