Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution: Poster #148

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Contribution: Poster #148

wants to merge 5 commits into from

Conversation

Alch-Emi
Copy link
Contributor

@Alch-Emi Alch-Emi commented Dec 2, 2020

Hey! I found out about this project by chance last night, and I really like what you're doing. I already submitted my signature, but I thought it might be neat if I could contribute something along the lines of a poster to visually display the oath. It's nothing fancy, but I ended up coming up with this poster.

You might notice that there's a couple small changes made to items 2 and 8. In order to fit them into the two line format, I had to shorten them a little bit. Specifically, the parts that I removed are:

  1. I will remember that programming is art as well as science, and that warmth, empathy and understanding may outweigh a clever algorithm or technical argument.

and

  1. I will consider the possible consequences of my code and actions. I will respect the difficulties of both social and technical problems.

I tried to remove sections that changed the meaning of the items as little as possible, but due to the concise nature of each item, and the amount that I needed to remove from item 2, the meaning may still have changed a good bit.

If you have any suggestions or feedback, feel free to let me know. Also, don't feel obligated to accept just because I made this, and I wouldn't be hurt if you decided you didn't want it.

This work is, to the greatest extent of my ability, released under CC0. This fact is also mentioned in the metadata of the poster.

Best,

Emi <3

Assets used:
 - Source Code Pro: (C) Adobe, SIL Open Font License
 - Nunito Sans: (C) Adobe, SIL Open Font License
 - GitHub & CC0 Icons: (C) Remix Design, Apache License 2.0, attribution waived
@Widdershin
Copy link
Owner

Wow, this is so cool!

The rewordings are great. Concise but still carry the original intent well.

Few questions:

  • Is there a command we can use to generate the pdf if we want to update the svg in future? I could probably figure one out but if you already have one you've used that would be great, we can add a little Makefile.
  • Rendering in Preview on macOS, the pdf only has numbers for items 04 and 10. Is that intended? If so was just curious what the rationale for picking those numbers was.

It would be cool in the future if we could write a little script to derive the SVG from the readme itself, unify the wording and automate regenerating it. Either way I'm happy to include this in the repo as an associated work 🙂

@Alch-Emi
Copy link
Contributor Author

Alch-Emi commented Dec 2, 2020

Is there a command we can use to generate the pdf if we want to update the svg in future? I could probably figure one out but if you already have one you've used that would be great, we can add a little Makefile.

The SVG itself is an Inkscape svg, and the original PDF was generated with Inkscape, so I'd assume that there should be a way to do it through the Inkscape command line tool, although it may be easier to just render edits using the Inkscape GUI, since it's likely that that's how any future edits to the poster would be made. If you're really interested though, I can try to figure out the Inkscape command.

Rendering in Preview on macOS, the pdf only has numbers for items 04 and 10. Is that intended? If so was just curious what the rationale for picking those numbers was.

That is definitely not intentional. This is what the render is supposed to look like:

image

If I had to guess, that sounds like there might be a problem with embedding or reading the fonts from the PDF. It could be a bug with Preview too, does it look right if you view it in a browser? A few possible solutions:

  • I can turn on text-to-path conversion in rendering the PDF, which would almost certainly fix the problem, at the cost of losing the ability for the PDF to be machine readable, which would potentially cost searchability and SEO, as well as the ability to copy/paste text from the document, and may increase file size slightly
  • We could render a PNG instead of or in addition to the PDF, which would cost resolution (being a finite-resolution bitmap instead of a scalable vector), machine readability, and print-friendliness, but is almost guaranteed to be displayed correctly on every machine
  • Iff this is only a problem with Preview, we could leave the PDF as is, which might reduce repository accessibility to MacOS users. We would probably want to avoid this.

I'm leaning towards option two, but the call is yours.

It would be cool in the future if we could write a little script to derive the SVG from the readme itself

That would certainly be very cool, but likely quite difficult. There's a few little tweaks like centring and line height that are easy for a human to make, but might be pretty annoying to automate. I don't think that that's a task I'd be up to myself, although it would be awesome if someone else wanted to take that up!

@Alch-Emi
Copy link
Contributor Author

Alch-Emi commented Dec 3, 2020

I just switched the monospace font from Source Code Pro to Recursive Mono (which I actually like a bit more). Does that render any better by chance?

Intended render

image

Dang what is with that *one spot*
@Widdershin
Copy link
Owner

Hmmm still rendering strangely on macOS, but working totally fine in the Github preview now (don't think it was rendering there before).

I'll have a look at it in InkScape on my machine after work today, will get back to you later on 👍

@Alch-Emi
Copy link
Contributor Author

Hey @Widdershin, I was wondering if you'd had a chance to take a look at this. If you're busy, I totally understand, but I just wanted to make sure it wasn't forgotten

@Widdershin
Copy link
Owner

Hi @Alch-Emi,

Thanks for following up! You've not been forgotten, my Dec/Jan was just pretty wild and I didn't have much time for OSS. I'll try to get to this soon :)

@Alch-Emi
Copy link
Contributor Author

Alch-Emi commented Jan 30, 2021 via email

@sai-manoj-kumar
Copy link
Contributor

image
I tested this on Inkscape on my macbook. Is this okay?

The text looks too close to the numbers. PDF still doesn't render all the numbers in the Preview app. It is rendered as expected when I open it with a browser though.

@Alch-Emi
Copy link
Contributor Author

It looks like you're missing a couple fonts? You should be able to grab them off of Google Fonts though I think.

As for the missing numbers, it's a shame that it's still a problem. I wonder if we could convert just the numbers to paths, and leave the text as text?

Also, did the fonts show up right in the PDF?

@Widdershin
Copy link
Owner

Sorry I still haven't followed up on this, have been stupid busy.

I wonder if we could convert just the numbers to paths, and leave the text as text?

That sounds like a good idea. Are there any other changes you'd like to make before we merge? I added another tenet just to make life difficult 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants