-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WalletGeneration.md #1813
base: master
Are you sure you want to change the base?
Conversation
I noticed the ASCII flowchart and I thought I'd take a crack at converting it to mermaid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't mean to give unwanted work to anyone! I'm just fond of viewing mermaid charts over ASCII versions -- less cognitive friction IMHO. I won't take offence if you don't find it worthwhile. All the best! |
@watou |
```mermaid flowchart TD ent[Entropy] --> jctA(( )) wl[Word list] --> jctA jctA --> mne[Mnemonics] mne --> jctB(( )) jctB --> seed[Seed] seed --> extkey[Extended Key] extkey --> privkey[Private Key] privkey --> jctC(( )) pass[Passphrase] ----> jctB & jctC net[Network] --> jctC jctC --> encsec[Encrypted Secret] encsec --> last["`Save encrypted secret+chaincode+ Fingerprint+ExtPub`"] ```
replaced mermaid text with image
```mermaid flowchart TD ent[Entropy] & wl[Word list] --> mne[Mnemonics] mne --> seed[Seed] seed --> extkey[Extended Key] extkey --> privkey[Private Key] privkey --> encsec[Encrypted Secret] pass[Passphrase] ----> seed pass -- This is needed to use BIP38 --> encsec net[Network] --> encsec encsec --> last["`Save encrypted secret + chaincode + Fingerprint + ExtPub`"] ```
Fixed image reference, to new image.
removed old image version in wrong place
Hopefully last commits are good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the Passphrase
at the top? I would rather see it aligned with the Mnemonics
.
I am not sure This step is needed to use bip38
is at the right place.
```mermaid flowchart TD ent[Entropy] & wl[Word list] --> mne[Mnemonics] mne --> seed[Seed] seed --> extkey[Extended Key] extkey --> privkey["`Private Key (This is needed to use BIP38)`"] privkey --> encsec[Encrypted Secret] pass[Passphrase] --> seed pass --> encsec net[Network] --> encsec encsec --> last["`Save encrypted secret + chaincode + Fingerprint + ExtPub`"] ```
I noticed the ASCII flowchart and I thought I'd take a crack at converting it to mermaid.