Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reissuance request #98

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

nopara73
Copy link
Contributor

@nopara73 nopara73 commented Feb 4, 2021

This PR adds a new type of reissuance request (it's just a fake request for illustration that there's such a thing.)

Note, I did not update the svg as I'm not sure if this is correct.

@nopara73 nopara73 requested a review from nothingmuch February 4, 2021 13:47
@nopara73
Copy link
Contributor Author

nopara73 commented Feb 5, 2021

image

participant Coordinator
participant Alice1
participant Alice2
participant Bob
database Mempool

title Scenario: A Participant Is Consolidating 2 Coins (Alice1, Alice2) Into 1 (Bob)\n
title Scenario: A Participant Is Consolidating 2 Coins (Alice1, Alice2) Into 1 (Bob) with a fake reissuance request \n
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is fake the proper word here?

Copy link
Contributor

@MaxHillebrand MaxHillebrand Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title Scenario: A Participant Is Consolidating 2 Coins (Alice1, Alice2) Into 1 (Bob) with a fake reissuance request \n
title Scenario: A Participant Is Consolidating 2 Coins (Alice1, Alice2) Into 1 (Bob) with an unnecessary reissuance request \n

@nopara73 nopara73 marked this pull request as draft February 5, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants