Drop Python 3.9 support and add DOLFINx v0.8 support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=======================================
+ Coverage 96.3% 96.9% +0.7%
=======================================
Files 1 1
Lines 186 191 +5
Branches 37 38 +1
=======================================
+ Hits 179 185 +6
+ Misses 5 4 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
matt-graham
changed the title
|
@samcunliffe not sure if you have bandwidth to review this at the moment - no problem if you want to leave it till you're on project in August! From meeting last week it seems that The codecov/patch fail I think is just because codecov doesn't seem to hit bits of code in |
samcunliffe
approved these changes
Jul 23, 2024
| @@ -23,7 +23,7 @@ jobs: | |||
| - name: Set up Python | |||
| uses: actions/setup-python@v4 | |||
| with: | |||
| python-version: 3.9 | |||
| python-version: 3.x | |||
| except ImportError: | ||
| # Compatibility w [email protected]: if the new functionspace function is not in DOLFINx | ||
| # then use the class constructor directly. | ||
| from dolfinx.fem import FunctionSpace as functionspace # noqa: N813 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds DOLFINx v0.8 to test matrix and updates usages of DOLFINx API to ensure compatibility across versions v0.6 through v0.8.
Also drops Python 3.9 support on the basis this is now > 3 years old and out of both NEP29 and SPEC0 recommended support windows, and our test matrix is getting a bit unwieldy.
Also updates our type hints to use
|in place of explicitUnionorOptionalwhere appropriate, and addsstrict=Trueargument to a call tozip.