-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphing property-level dependencies in disease modules #1475
base: master
Are you sure you want to change the base?
Conversation
…DENCIES are declared
…DENCIES and ADDITIONAL_DEPENDENCIES are declared
…DENCIES and ADDITIONAL_DEPENDENCIES are declared
…DENCIES and ADDITIONAL_DEPENDENCIES are declared
…DENCIES and ADDITIONAL_DEPENDENCIES are declared
…DENCIES and ADDITIONAL_DEPENDENCIES are declared
…DENCIES and ADDITIONAL_DEPENDENCIES are declared
…ease modules. Process: collects properties from each disease (+lifestyle) module, and compares them to the scripts of the remaining disease (+lifestyle) module.
…w/graph_dependencies # Conflicts: # src/scripts/longterm_projections/property_dependency_graph.py
…w/graph_dependencies
Hi @RachelMurray-Watson |
Yes! I actually meant to come back to this, but for the property-level graphs, I don't actually need to know the module dependencies at all, so I can remove that from this PR, and perhaps add it as an issue that not all modules declare all of their dependencies? |
That would be perfect! |
Done! |
This PR creates two graphs: one shows the macro-level depedencies between disease modules, and one that shows which properties from one disease module are used in another.
NOTE: In order to create a graph of the dependencies between disease modules, I need to ensure that all disease modules have declared their dependencies. I have gone through the disease modules manually and updated dependencies where I have noted they're missing, but I would appreciate it if module authors could double-check this and/or remove any modules that are no longer needed.
This was all done on cold reads of the model scripts.
In the future, could use the linear module function + runs of the module to map what exactly the properties are acting upon.