You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Essentially a tracker for our progress towards #70.
Logging which tdms classes need to be detached from MATLAB
Non-MATLAB classes we might want to flatten
Whilst it won't be necessary (we can just reshape buffers before writing/reading) we might want to rework the classes below to have flat, strided vectors to store their data rather than pointers to pointers.
Tensor3D
Matrix
Storage classes
Classes that are inherited from by other classes, or are simply used to store or interact with MATLAB objects.
Files that define functions that operate on MATLAB objects.
array_init.h/cpp
mesh_base.h/cpp
matlabio.h/cpp (likely will be deleted)
mat_io.h/cpp (likely will be deleted)
Other Classes
InputMatrices can be removed once all functions that need to read into have MATLAB removed. simulation_manager will need to be passed the name of the HDF5 file, or a HDF5Reader instance.
OutputMatrices no longer needs to hold MATLAB pointers, instead should use HDF5Writer to produce the output. Removing MATLAB from each of the written out classes should involve implementing such functionality in this class, in which case it might be redundant / separated from MATLAB by this stage anyway.
Test Classes
AbstractArrayTestClass and all its dependencies will need to be adjusted accordingly. Recommend doing this whilst tackling each class that is tested by this.
The text was updated successfully, but these errors were encountered:
Essentially a tracker for our progress towards #70.
Logging which
tdms
classes need to be detached from MATLABNon-MATLAB classes we might want to flatten
Whilst it won't be necessary (we can just reshape buffers before writing/reading) we might want to rework the classes below to have flat, strided vectors to store their data rather than pointers to pointers.
Tensor3D
Matrix
Storage classes
Classes that are inherited from by other classes, or are simply used to store or interact with MATLAB objects.
MaterialCollection
(DetachXYZVector
from MATLAB #315)CCollectionBase
(DetachXYZVector
from MATLAB #315)DCollectionBase
(DetachXYZVector
from MATLAB #315)Vector
(this class can almost surely be replaced withstd::vector
now that we can read MATLAB buffers via HDF5).Dimensions
(this could quite easily be replaced withH5Dimensions
from Infrastructure for removingMATLAB
#281)Field
SplitField
LoopVariables
(just for the copy of the electric field at the previous iteration)Classes that are only read into
Classes that are read from the input file, or initialised by passing
mxArray
pointers.CMaterial
(inheritsMaterialCollection
,CCollectionBase
) (DetachXYZVector
from MATLAB #315)DMaterial
(inheritsMaterialCollection
,DCollectionBase
) (DetachXYZVector
from MATLAB #315)DispersiveMultiLayer
GratingStructure
(inheritsMatrix
)FrequencyExtractVector
(DetachVector
s from MATLAB #328)FrequencyVectors
Pupil
(inheritsMatrix
)DTilde
(inheritsTensor3D
)IncidentField
(inheritsTensor3D
)fdtdGridInitialiser
InterfaceComponent
Cuboid
Source
(requirescomplex
casting)Classes that are written out
Classes that need some (or all) of their data written to the output file.
FieldComponentsVectors
(inheritsVector
, part ofVertexPhasors
) (DetachVector
s from MATLAB #328)Vertices
(inheritsMatrix
, part ofVertexPhasors
)ElectricField
(inheritsField
)MagneticField
(inheritsField
)FieldSample
SurfacePhasors
VertexPhasors
IDVariables
Classes that are both read and written
WYTII.
TDFieldExporter2D
GridLabels
SimulatonManager
Dependent Functions
Files that define functions that operate on MATLAB objects.
array_init.h/cpp
mesh_base.h/cpp
matlabio.h/cpp
(likely will be deleted)mat_io.h/cpp
(likely will be deleted)Other Classes
InputMatrices
can be removed once all functions that need to read into have MATLAB removed.simulation_manager
will need to be passed the name of theHDF5
file, or aHDF5Reader
instance.OutputMatrices
no longer needs to holdMATLAB
pointers, instead should useHDF5Writer
to produce the output. Removing MATLAB from each of the written out classes should involve implementing such functionality in this class, in which case it might be redundant / separated from MATLAB by this stage anyway.Test Classes
AbstractArrayTestClass
and all its dependencies will need to be adjusted accordingly. Recommend doing this whilst tackling each class that is tested by this.The text was updated successfully, but these errors were encountered: