Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config release docs #44

Merged
merged 16 commits into from
Jan 29, 2024
Merged

Config release docs #44

merged 16 commits into from
Jan 29, 2024

Conversation

tim-band
Copy link
Collaborator

@tim-band tim-band commented Dec 19, 2023

Lots of changes to make qw demoable.
Closes #16, closes #25, closes #39
Addresses (no tests) #17, #36

Copy link
Collaborator

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I guess there's not much time so it was a pragmatic choice but felt a bit light on testing

Comment on lines +16 to +17
class DiffElement:
"""A potential update to the local store."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh fun

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wanted to be able to separate out the gathering of the diffs from the acceptance of them, so that required this class.

src/qw/design_stages/checks.py Show resolved Hide resolved
@tim-band tim-band merged commit 9a49b9e into UCL-ARC:main Jan 29, 2024
4 checks passed
@tim-band tim-band deleted the config-release-docs branch January 29, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants