Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock remote issues #11

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Mock remote issues #11

merged 6 commits into from
Oct 26, 2023

Conversation

stefpiatek
Copy link
Collaborator

@stefpiatek stefpiatek commented Oct 25, 2023

  • Not quite convinced that I've got the best place for processing raw issue data into design stages so any thoughts there would be good
  • Moved the remote repository files into their own modules and made use of abstract base classes so we have to implement properties
  • in tests, can read from filesystem, imagine during testing we may need to pass in a temporary test directory, which we can setup there. Using the frontmatter in markdown to keep all the values that we'd get some the github object
  • Next steps might be persisting the json data to a file, then maybe working on the freeze to be able to find changes to ignore or increment the version?

@stefpiatek stefpiatek changed the title Make remote repo module and add to issue properties Mock remote issues Oct 25, 2023
Copy link
Collaborator

@tim-band tim-band left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one simple change

tests/helpers/mock_service.py Outdated Show resolved Hide resolved
@stefpiatek stefpiatek marked this pull request as ready for review October 26, 2023 09:30
@tim-band tim-band merged commit a93b679 into stef/fix-remote-parsing Oct 26, 2023
2 checks passed
@tim-band tim-band deleted the stef/mock-github branch October 26, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants