Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1921] Add median aggregator #7321

Open
wants to merge 10 commits into
base: add-standard-deviation-and-variance-aggregations
Choose a base branch
from
Open

[NU-1921] Add median aggregator #7321

wants to merge 10 commits into from

Conversation

paw787878
Copy link
Contributor

@paw787878 paw787878 commented Dec 12, 2024 •
edited
Loading

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe docs ui labels Dec 12, 2024
@paw787878 paw787878 changed the base branch from staging to add-standard-deviation-and-variance-aggregations December 12, 2024 09:32
@paw787878 paw787878 marked this pull request as ready for review December 12, 2024 09:33
@paw787878 paw787878 force-pushed the add-standard-deviation-and-variance-aggregations branch from acf33c6 to c665586 Compare December 12, 2024 10:02
jedrz
jedrz reviewed Dec 12, 2024
View reviewed changes
docs/scenarios_authoring/AggregatesInTimeWindows.md Show resolved Hide resolved
.../test/scala/pl/touk/nussknacker/engine/flink/util/transformer/aggregate/AggregatesSpec.scala Outdated Show resolved Hide resolved
utils/math-utils/src/main/scala/pl/touk/nussknacker/engine/util/MathUtils.scala Show resolved Hide resolved
.../scala/pl/touk/nussknacker/engine/flink/util/transformer/aggregate/median/MedianHelper.scala Outdated Show resolved Hide resolved
.../scala/pl/touk/nussknacker/engine/flink/util/transformer/aggregate/median/MedianHelper.scala Show resolved Hide resolved
.../scala/pl/touk/nussknacker/engine/flink/util/transformer/aggregate/median/MedianHelper.scala Show resolved Hide resolved
.../scala/pl/touk/nussknacker/engine/flink/util/transformer/aggregate/median/MedianHelper.scala Outdated Show resolved Hide resolved
@github-actions github-actions bot removed ui client client main fe labels Dec 12, 2024
jedrz
jedrz reviewed Dec 13, 2024
View reviewed changes
docs/Changelog.md Outdated Show resolved Hide resolved
jedrz
jedrz reviewed Dec 13, 2024
View reviewed changes
...est/scala/pl/touk/nussknacker/engine/flink/util/transformer/aggregate/TransformersTest.scala
val aggregateVariables = runCollectOutputAggregate[Number](id, model, testProcess)
aggregateVariables.length shouldEqual (2)
aggregateVariables(0) shouldEqual 1.0
require((aggregateVariables(1).asInstanceOf[Double].isNaN))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use matcher :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedrz jedrz jedrz approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paw787878 @jedrz