Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added polymorphism test and virtual functions #2279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added polymorphism test and virtual functions #2279

wants to merge 1 commit into from

Conversation

mondus
Copy link

@mondus mondus commented May 15, 2024

Pull request fixes #2278 by making Writer class functions virtual to allow correct behaviour when PrettyWriter is cast to the base class.

Changes made

  • Unit Test which ensures that PrettyWriter maintains pretty writing when cast to Writer
  • Changes to Writer class functions to make them virtual

@tencent-adm
Copy link
Member

tencent-adm commented May 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polymorphism not used for PrettyWriter
2 participants
@mondus @tencent-adm