Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameters to render_html and render_latex to export to files #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MaxGhenis
Copy link
Contributor

Fixes #29. Also adds function documentation for render_html and render_latex.

@toobaz
Copy link
Collaborator

toobaz commented Jun 4, 2020

Just one thought: pandas.DataFrame.to_latex() has a similar argument, but when passed, the method it will not return the representation as string. To be honest I don't see any downside with your approach, not even of consistency (worst case scenario, users accustomed to pandas might not notice that something is being returned), but I was just wondering if there is any.

@MaxGhenis
Copy link
Contributor Author

MaxGhenis commented Jun 4, 2020

Good point, I think it makes more sense to follow pandas's lead and suppress printing if out is provided. For example, my workflow has been to first print the table in HTML in my Jupyter notebook, then export to tex if it looks good; neither the raw html nor tex outputs are very useful just as printed results.

If you agree I'll go ahead and make the change to this PR.

@MaxGhenis
Copy link
Contributor Author

@toobaz please let me know if you'd prefer output suppressed when providing out.

@toobaz
Copy link
Collaborator

toobaz commented Jun 27, 2020

@toobaz please let me know if you'd prefer output suppressed when providing out.

Yes, please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to write render_html or render_latex output to a file
2 participants