Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize LoadsHistorySyncer (backport #53864) #53958

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 16, 2024

Why I'm doing:

  1. If there are no load jobs, LoadsHistorySyncer still runs.
  2. LoadsHistorySyncer does not ignore its own load job, so cause Infinite loop.

What I'm doing:

  1. Record the last sync time, if there are no new load jobs, do not run sync SQL.
  2. Ignore the LoadsHistorySyncer triggered dml SQL.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

## Why I'm doing:
1. If there are no load jobs, LoadsHistorySyncer still runs.
2. LoadsHistorySyncer does not ignore its own load job, so cause Infinite loop.

## What I'm doing:
1. Record the last sync time, if there are no new load jobs, do not run sync SQL.
2. Ignore the LoadsHistorySyncer triggered dml SQL.

Signed-off-by: gengjun-git <[email protected]>
(cherry picked from commit 884981f)
Copy link

sonarcloud bot commented Dec 16, 2024

@wanpengfei-git wanpengfei-git merged commit 79d3777 into branch-3.4 Dec 16, 2024
38 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.4/pr-53864 branch December 16, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants