Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix]If the OP_DROP_TABLE_V2 event is lost, it will cause a null pointer error to be reported when processing the OP_ADD_PARTITION_V2 event. #53953

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhangheihei
Copy link
Contributor

@zhangheihei zhangheihei commented Dec 15, 2024

Why I'm doing:

  1. [BugFix]The OP_DROP_TABLE_V2 event is not triggered when an error is reported for dropping a materialized view. #53951 result OP_DROP_TABLE_V2 lost, but nameToTable/idToTable is clear,so can create a materialized view with the same name. For examplt, old mv tableId is 100001, new tableId is 100002,mv name is test.dws_ofo_mv4.
  2. OP_CREATE_TABLE_V2 event will not take effect because OP_DROP_TABLE_V2 is lost, so checkpoint thread/follwer fe remains test.dws_ofo_mv4-100001.
  3. The object of refresh is test.dws_ofo_mv4-100002, so the null pointer is encountered in the OP_ADD_PARTITION_V2 event.

What I'm doing:

Fixes #53955

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@zhangheihei zhangheihei requested a review from a team as a code owner December 15, 2024 15:45
…ointer error to be reported when processing the OP_ADD_PARTITION_V2 event.

Signed-off-by: edwinhzhang <[email protected]>
Signed-off-by: edwinhzhang <[email protected]>
Copy link

sonarcloud bot commented Dec 15, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 1 / 4 (25.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/server/LocalMetastore.java 1 4 25.00% [1940, 1943, 1944]

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@@ -1936,7 +1936,14 @@ public void replayCreateTable(CreateTableInfo info) {
Locker locker = new Locker();
locker.lockDatabase(db.getId(), LockType.WRITE);
try {
db.registerTableUnlocked(table);
if (!db.registerTableUnlocked(table)) {
if (table != null && !table.isTemporaryTable()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not reasonable to remove the original table if create failed.
As you said
In replay create table, there must not be a table with the same name, unless there is a bug.
We should fix the bug that causes the duplicate table names instead of ignoring it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But after an error occurs, there needs to be a defense to recover the FE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE crashes because of null pointer
2 participants