-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix]If the OP_DROP_TABLE_V2 event is lost, it will cause a null pointer error to be reported when processing the OP_ADD_PARTITION_V2 event. #53953
base: main
Are you sure you want to change the base?
Conversation
…ointer error to be reported when processing the OP_ADD_PARTITION_V2 event. Signed-off-by: edwinhzhang <[email protected]>
6ad4c6c
to
b0acb3d
Compare
Signed-off-by: edwinhzhang <[email protected]>
14d6a6a
to
f818657
Compare
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 1 / 4 (25.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
@@ -1936,7 +1936,14 @@ public void replayCreateTable(CreateTableInfo info) { | |||
Locker locker = new Locker(); | |||
locker.lockDatabase(db.getId(), LockType.WRITE); | |||
try { | |||
db.registerTableUnlocked(table); | |||
if (!db.registerTableUnlocked(table)) { | |||
if (table != null && !table.isTemporaryTable()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not reasonable to remove the original table if create failed.
As you said
In replay create table, there must not be a table with the same name, unless there is a bug.
We should fix the bug that causes the duplicate table names instead of ignoring it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But after an error occurs, there needs to be a defense to recover the FE.
Why I'm doing:
What I'm doing:
Fixes #53955
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: