Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add add_shard_listener in StarOSWorker #53525

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Dec 4, 2024

  • be able to hook callbacks when new shards added to the worker in shared-data mode

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@kevincai kevincai changed the title [Enhancement] add add_shard_listner in StarOSWorker [Enhancement] add add_shard_listener in StarOSWorker Dec 4, 2024
@kevincai
Copy link
Contributor Author

kevincai commented Dec 9, 2024

@Mergifyio rebase

* be able to hook callbacks when new shards added to the worker in
  shared-data mode

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Copy link
Contributor

mergify bot commented Dec 9, 2024

rebase

✅ Branch has been successfully rebased

Copy link

github-actions bot commented Dec 9, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 9, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 9, 2024

[BE Incremental Coverage Report]

pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/service/staros_worker.cpp 4 4 100.00% []
🔵 be/src/service/staros_worker.h 3 3 100.00% []

@wyb wyb enabled auto-merge (squash) December 16, 2024 02:41
@wyb wyb merged commit aa4acd7 into StarRocks:main Dec 16, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants