Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] skip add the alias into fieldMapping when order by expr not referenced this alias (backport #50546) #50565

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 2, 2024

Why I'm doing:

failed to execute select v1 cc, v2 cc from tbl order by v3 with error info column cc is ambiguous

What I'm doing:

order by expr may reference the alias. We need put the alias into the fieldMappings or the expressionToColumns.
if the alias not be used in the order by expr like:
select v1 cc, v2 cc from tbl order by v3
We just add the slotRef(cc) to columnRefOperator in the
expressionToColumns to ensure this projection can output v1 with alias cc, v2 with alias cc and v3.
We don't need to ensure the uniqueness of the alias in the fieldMappings.

if the alias used in the order by expr like:
select v1 v3, v2 cc from (select abs(v1) v1, abs(v2) v2, v3 from t0) t1 order by t1.v3
order by expr t1.v3 referenced the v1 with alias v3, we need set the fieldMappings to ensure order by
expr can be resolved.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50546 done by [Mergify](https://mergify.com). ## Why I'm doing: failed to execute `select v1 cc, v2 cc from tbl order by v3` with error info `column cc is ambiguous` ## What I'm doing: order by expr may reference the alias. We need put the alias into the fieldMappings or the expressionToColumns. if the alias not be used in the order by expr like: `select v1 cc, v2 cc from tbl order by v3` We just add the slotRef(cc) to columnRefOperator in the expressionToColumns to ensure this projection can output v1 with alias cc, v2 with alias cc and v3. We don't need to ensure the uniqueness of the alias in the fieldMappings.

if the alias used in the order by expr like:
select v1 v3, v2 cc from (select abs(v1) v1, abs(v2) v2, v3 from t0) t1 order by t1.v3
order by expr t1.v3 referenced the v1 with alias v3, we need set the fieldMappings to ensure order by
expr can be resolved.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…referenced this alias (#50546)

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 885c500)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/OrderByTest.java
@mergify mergify bot added the conflicts label Sep 2, 2024
Copy link
Contributor Author

mergify bot commented Sep 2, 2024

Cherry-pick of 885c500 has failed:

On branch mergify/bp/branch-2.5/pr-50546
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 885c5009be.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/QueryTransformer.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/OrderByTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Sep 2, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-50546 branch September 2, 2024 11:03
@packy92 packy92 restored the mergify/bp/branch-2.5/pr-50546 branch September 3, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant